-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecate_function
and deprecate_arguments
decorators (deprecated in 0.24)
#13448
base: main
Are you sure you want to change the base?
Remove deprecate_function
and deprecate_arguments
decorators (deprecated in 0.24)
#13448
Conversation
One or more of the following people are relevant to this code:
|
deprecate_function and
deprecate_arguments` decorators (deprecated in 0.24)deprecate_function
and deprecate_arguments
decorators (deprecated in 0.24)
Pull Request Test Coverage Report for Build 11895809149Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just left a reno suggestion. It also looks like qiskit_aer is raising deprecation warnings in the neko tests, I will look into that.
releasenotes/notes/deprecate_arguments_and_deprecate_function-5e19f6f049fa489c.yaml
Outdated
Show resolved
Hide resolved
…5e19f6f049fa489c.yaml Co-authored-by: Elena Peña Tapia <[email protected]>
Thanks for the review! Let's hold this one until Friday so we dont affect the queue for the release on Thursday. |
Summary
The
deprecate_function
anddeprecate_arguments
decorators had been the legacy way to define deprecated methods and arguments. They had been deprecated since 0.24 (ref #9676), released on May 2023.Time to remove them in 2.0.