Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecate_function and deprecate_arguments decorators (deprecated in 0.24) #13448

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 15, 2024

Summary

The deprecate_function and deprecate_arguments decorators had been the legacy way to define deprecated methods and arguments. They had been deprecated since 0.24 (ref #9676), released on May 2023.

Time to remove them in 2.0.

@1ucian0 1ucian0 added this to the 2.0.0 milestone Nov 15, 2024
@1ucian0 1ucian0 requested a review from a team as a code owner November 15, 2024 20:47
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 changed the title Remove deprecate_function and deprecate_arguments` decorators (deprecated in 0.24) Remove deprecate_function and deprecate_arguments decorators (deprecated in 0.24) Nov 15, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11895809149

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.006%) to 88.938%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 92.27%
crates/accelerate/src/unitary_synthesis.rs 1 92.2%
crates/qasm2/src/lex.rs 2 92.48%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 11842392021: -0.006%
Covered Lines: 79375
Relevant Lines: 89248

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just left a reno suggestion. It also looks like qiskit_aer is raising deprecation warnings in the neko tests, I will look into that.

…5e19f6f049fa489c.yaml

Co-authored-by: Elena Peña Tapia <[email protected]>
@1ucian0 1ucian0 added the on hold Can not fix yet label Nov 19, 2024
@1ucian0
Copy link
Member Author

1ucian0 commented Nov 19, 2024

Thanks for the review! Let's hold this one until Friday so we dont affect the queue for the release on Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Can not fix yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants