Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the function to get topological generations #1053

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Add the function to get topological generations #1053

merged 5 commits into from
Jan 15, 2024

Conversation

inmzhang
Copy link
Contributor

@inmzhang inmzhang commented Jan 14, 2024

Closes #1014

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Jan 14, 2024

Pull Request Test Coverage Report for Build 7522341357

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 95.923%

Totals Coverage Status
Change from base Build 7513108802: -0.03%
Covered Lines: 16024
Relevant Lines: 16705

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making your first contribution!

Overall the code looks good and I don't think there is a need to change anything for functionality. I left one optional comment about the DAG check.

You also need to sign the CLA to make the CLA bot accept your PR

@IvanIsCoding IvanIsCoding merged commit ec74fe9 into Qiskit:main Jan 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an equivalent to networkx's topological_generations?
4 participants