Initial hyperlink implementation. #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of hyperlinks, set BETTER_EXCEPTIONS_HYPERLINKS=1 to activate.
stuaxo
force-pushed
the
feature/hyperlinks
branch
from
28af958 to
f60e22d
Compare
Qix-
requested changes
Sep 28, 2019
|
Silly question, if I click `resolve conversation' will it apply the suggested change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of hyperlinks, set BETTER_EXCEPTIONS_HYPERLINKS=1 to activate.
This is not as useful as I expected as there line numbers can't be implemented yet [1], I'd probably still use this though.
I assume this needs tests, I haven't looked at how to do these yet.
[1]
https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#gistcomment-2872221
TODO: Don't output hyperlink for filenames like
<console>