Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in foreign blockchain server configuration add and remove capa… #194

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

kennycud
Copy link

…bilities. Also adding in connection recording and connection setting capabilities.

…bilities. Also adding in connection recording and connection setting capabilities.
@QuickMythril
Copy link

I have some questions about these API calls. When using addserver is that a permanent change to the list of servers, or just for the current session? It looks like some code was copied and pasted in a few places, as the response sections for the API calls say "true if removed, false if not found" which only makes sense for removeserver and not the others. Has anyone looked at the other pull request related to ElectrumX server settings which allows people to make permanent additions to their servers using the settings.json file? Perhaps a combination of these two methods could allow people to use the UI to make an API call that would update the settings file. That's something we've needed to work on as well anyway. See: #178

@kennycud
Copy link
Author

the addserver comment "true if removed, false if not found" is wrong, it should state "true if added, false if not added", I will update these comments soon

@kennycud
Copy link
Author

addserver changes the session only

@crowetic crowetic merged commit 5910cef into Qortal:master Jun 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants