fix: return the error in case of SSH connection error (#396)

Qovery · Dec 2, 2024 · 6be5cf1 · 6be5cf1
1 parent 3f345e0
commit 6be5cf1
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/cmd/admin_k9s.go b/cmd/admin_k9s.go
@@ -127,18 +127,16 @@ func setupSSHConnection(ctx context.Context) (*exec.Cmd, error) {
 	}
 
 	if err := waitForSSHConnection(ctx, "localhost:1080", 30*time.Second); err != nil {
-		err := sshCmd.Process.Kill()
-		if err != nil {
-			return nil, err
+		if killErr := sshCmd.Process.Kill(); killErr != nil {
+			log.Errorf("failed to kill SSH process: %v", killErr)
 		}
 		return nil, fmt.Errorf("error waiting for SSH connection: %v", err)
 	}
 
 	log.Info("SSH connection established successfully")
 	if err := os.Setenv("HTTPS_PROXY", "socks5://localhost:1080"); err != nil {
-		err := sshCmd.Process.Kill()
-		if err != nil {
-			return nil, err
+		if killErr := sshCmd.Process.Kill(); killErr != nil {
+			log.Errorf("failed to kill SSH process: %v", killErr)
 		}
 		return nil, fmt.Errorf("failed to set HTTPS_PROXY: %v", err)
 	}