fix: add support for the new Cluster State enum that contains INVALID_CREDENTIALS #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pggb25
changed the title
benjaminch
approved these changes
Oct 3, 2023
ghost
reviewed
Oct 3, 2023
| @@ -1402,6 +1424,13 @@ func IsTerminalState(state qovery.StateEnum) bool { | |||
| strings.HasSuffix(string(state), "ERROR") | |||
| } | |||
|
|
|||
| func IsTerminalClusterState(state qovery.ClusterStateEnum) bool { | |||
There was a problem hiding this comment.
Maybe having invalid credentials should be considered as a terminal state ?
There was a problem hiding this comment.
yes I didn't see the strings.HasSuffix(string(state), "ERROR")
ghost
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.