Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of DP8. #13

Merged
merged 35 commits into from
Jan 2, 2024
Merged

Implementation of DP8. #13

merged 35 commits into from
Jan 2, 2024

Conversation

weinbe58
Copy link
Member

No description provided.

@weinbe58 weinbe58 marked this pull request as draft December 20, 2023 22:17
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ccc9854) 98.66% compared to head (3e44275) 97.34%.

Files Patch % Lines
src/dp8/solver.jl 95.94% 3 Missing ⚠️
src/dp5/solver.jl 71.42% 2 Missing ⚠️
src/dp8/helpers.jl 98.00% 1 Missing ⚠️
src/hinit.jl 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   98.66%   97.34%   -1.32%     
==========================================
  Files           7       11       +4     
  Lines         224      339     +115     
==========================================
+ Hits          221      330     +109     
- Misses          3        9       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/dp5/params.jl Show resolved Hide resolved
src/dp8/checks.jl Outdated Show resolved Hide resolved
src/types.jl Outdated Show resolved Hide resolved
@weinbe58
Copy link
Member Author

weinbe58 commented Dec 22, 2023

Screenshot 2023-12-22 at 3 58 50 PM

new DP8Solver implementation: For solving from point A to B we're about 10x faster than DiffEq.

@weinbe58 weinbe58 marked this pull request as ready for review December 23, 2023 17:21
@weinbe58 weinbe58 requested a review from Roger-luo December 23, 2023 17:26
@weinbe58 weinbe58 requested a review from johnzl-777 December 23, 2023 17:37
benchmarks/rabi-diffeq.jl Outdated Show resolved Hide resolved
benchmarks/type_stab.jl Show resolved Hide resolved
src/interface.jl Outdated Show resolved Hide resolved
@weinbe58 weinbe58 requested a review from johnzl-777 January 2, 2024 18:39
src/interface.jl Outdated Show resolved Hide resolved
src/interface.jl Outdated Show resolved Hide resolved
@weinbe58 weinbe58 merged commit 4aba651 into main Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants