Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding 'L2' to lattice constructors #749

Merged
merged 4 commits into from
Oct 25, 2023
Merged

adding 'L2' to lattice constructors #749

merged 4 commits into from
Oct 25, 2023

Conversation

weinbe58
Copy link
Member

No description provided.

@weinbe58 weinbe58 added the breaking This PR breaks the current API label Oct 24, 2023
@weinbe58 weinbe58 self-assigned this Oct 24, 2023
@weinbe58 weinbe58 linked an issue Oct 24, 2023 that may be closed by this pull request
Improvement for lattice functions #727
Closed
@weinbe58 weinbe58 requested a review from johnzl-777 October 24, 2023 17:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-25 17:05 UTC

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #749 (d2c4130) into main (24108b1) will increase coverage by 0.01%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   84.85%   84.87%   +0.01%     
==========================================
  Files          91       91              
  Lines        7732     7742      +10     
==========================================
+ Hits         6561     6571      +10     
  Misses       1171     1171
Files Coverage Δ
src/bloqade/codegen/common/json.py 66.07% <ø> (ø)
src/bloqade/ir/location/bravais.py 93.96% <100.00%> (+0.27%) ⬆️
src/bloqade/codegen/common/assign_variables.py 86.70% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

johnzl-777
johnzl-777 requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@johnzl-777 johnzl-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be some typos with the docstrings ("direction" vs. "diration") but other than that everything else looks good (:

src/bloqade/ir/location/bravais.py Outdated Show resolved Hide resolved
@weinbe58 weinbe58 requested a review from johnzl-777 October 25, 2023 16:12
@johnzl-777 johnzl-777 merged commit cdda67b into main Oct 25, 2023
9 checks passed
@johnzl-777 johnzl-777 deleted the 727-improvement-for-lattice-functions branch October 25, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnzl-777 johnzl-777 johnzl-777 approved these changes

Assignees

@weinbe58 weinbe58

Labels
breaking This PR breaks the current API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement for lattice functions
2 participants
@weinbe58 @johnzl-777