Added check for hybrid Control/Matrix Gate classes + test #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rturrado
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Good work, @juanboschero !
Please consider my review as a set of comments and questions. I leave the final approval to Chris and Pablo.
Thanks!
pablolh
suggested changes
Feb 26, 2024
|
Your implementation is correct but doesn't scale I just had this idea, instead of my earlier comment: |
pablolh
reviewed
Feb 27, 2024
pablolh
reviewed
Mar 5, 2024
pablolh
force-pushed
the
88-make-sure-we-can-compare-a-matrixgate-and-a-controlledgate
branch
from
2b5ce76
to
22b0a54
Compare
juanboschero
force-pushed
the
88-make-sure-we-can-compare-a-matrixgate-and-a-controlledgate
branch
from
22b0a54
to
2b68d1f
Compare
pablolh
previously approved these changes
Mar 6, 2024
rturrado
reviewed
Mar 7, 2024
juanboschero
force-pushed
the
88-make-sure-we-can-compare-a-matrixgate-and-a-controlledgate
branch
from
fbd81d2
to
fa0592c
Compare
|
Make sure you rebase on top of latest |
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.10 to 9.5.11. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.5.10...9.5.11) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
- Configured equivalence of gates from subclass to base class - Renamed get_matrix to get_matrix_after_qubit_remapping and moved function to matrix_expander - Added tests to check equivalence between MatrixGate and ControlGate objects removed union import from squirrel_ir
juanboschero
force-pushed
the
88-make-sure-we-can-compare-a-matrixgate-and-a-controlledgate
branch
from
fa0592c
to
63b64d7
Compare
…and-a-controlledgate
pablolh
approved these changes
Mar 11, 2024
elenbaasc
deleted the
88-make-sure-we-can-compare-a-matrixgate-and-a-controlledgate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.