-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up GitHub actions #15
Conversation
@elenbaasc this pipeline fails on two things;
|
Hi Olaf, Thanks for the PR, I will fix the integration test and the Python versions |
Concerning this, I just noticed (as I'm building/testing it) that the quantum device connector has Although, OpenSquirrel doesn't have to follow this tight requirement, I think, and I don't see why it wouldn't support 3.8. |
e856228
to
ff934dc
Compare
Ah! Numpy doesn't support Python 3.9 apparently. So it'll be 3.9+ |
@pablolh the Quantum Device Connector is one of our internal applications and does not run client sided. This means that we can very much pin a specific python version and don't have to support all possible OS' and python versions. |
There is no support in Numpy for < 3.10? |
Sorry, I wrote it wrong. We require Numpy 1.26 apparently. So alternatively I can accept Numpy 1.24 |
That is entirely up to you/the project. It only means that the classifiers and matrix in the actions need to be updated |
804caf2
to
38c008a
Compare
I got it working! I thought that the Numpy package would specify this and that Poetry would deal with this alone, but no, I was getting no clean error and some build failure. Not sure why, anyway, it works now. Feel free to approve/merge whenever. |
Allow Numpy 1.24 otherwise we cannot support Python 3.8
Fix integration test accordingly
38c008a
to
06c243e
Compare
No description provided.