Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up GitHub actions #15

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Set up GitHub actions #15

merged 4 commits into from
Nov 17, 2023

Conversation

oschusler
Copy link
Contributor

No description provided.

@oschusler oschusler linked an issue Nov 15, 2023 that may be closed by this pull request
@oschusler oschusler changed the base branch from master to 13-integrate-tox November 15, 2023 19:39
@oschusler
Copy link
Contributor Author

@elenbaasc this pipeline fails on two things;

  1. In the pyproject.toml file you specify that the python version should be >= 3.10. Are you really sure you don't want to support 3.8 and 3.9? They are still in use
  2. There is a rounding error on macOS. This should be fixed for the integration tests

@oschusler oschusler marked this pull request as draft November 15, 2023 19:42
@oschusler oschusler self-assigned this Nov 15, 2023
@pablolh
Copy link
Contributor

pablolh commented Nov 16, 2023

Hi Olaf,

Thanks for the PR, I will fix the integration test and the Python versions

Base automatically changed from 13-integrate-tox to master November 16, 2023 12:03
@oschusler oschusler marked this pull request as ready for review November 16, 2023 13:59
pyproject.toml Outdated Show resolved Hide resolved
@pablolh
Copy link
Contributor

pablolh commented Nov 16, 2023

@oschusler

In the pyproject.toml file you specify that the python version should be >= 3.10.

Concerning this, I just noticed (as I'm building/testing it) that the quantum device connector has python = "^3.11" in its pyproject.toml
What's the reasoning behind this?

Although, OpenSquirrel doesn't have to follow this tight requirement, I think, and I don't see why it wouldn't support 3.8.

@pablolh
Copy link
Contributor

pablolh commented Nov 16, 2023

Ah! Numpy doesn't support Python 3.9 apparently. So it'll be 3.9+

@oschusler
Copy link
Contributor Author

@pablolh the Quantum Device Connector is one of our internal applications and does not run client sided. This means that we can very much pin a specific python version and don't have to support all possible OS' and python versions.

@oschusler
Copy link
Contributor Author

Ah! Numpy doesn't support Python 3.9 apparently. So it'll be 3.9+

There is no support in Numpy for < 3.10?

@pablolh
Copy link
Contributor

pablolh commented Nov 16, 2023

Sorry, I wrote it wrong.
Numpy 1.25+ doesn't support 3.8, but does support 3.9:
see https://endoflife.date/numpy

We require Numpy 1.26 apparently. So alternatively I can accept Numpy 1.24

@oschusler
Copy link
Contributor Author

Sorry, I wrote it wrong. Numpy 1.25+ doesn't support 3.8, but does support 3.9: see https://endoflife.date/numpy

We require Numpy 1.26 apparently. So alternatively I can accept Numpy 1.24

That is entirely up to you/the project. It only means that the classifiers and matrix in the actions need to be updated

@pablolh pablolh force-pushed the 12-set-up-github-actions branch 3 times, most recently from 804caf2 to 38c008a Compare November 16, 2023 17:13
@pablolh
Copy link
Contributor

pablolh commented Nov 16, 2023

I got it working!
I had to use multiple Python restricted dependencies in pyproject.toml:
using numpy 1.24 works with Python 3.8, but not Python 3.12
using numpy 1.26 works with 3.12 but not 3.8

I thought that the Numpy package would specify this and that Poetry would deal with this alone, but no, I was getting no clean error and some build failure. Not sure why, anyway, it works now.

Feel free to approve/merge whenever.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@oschusler oschusler merged commit 14c831c into master Nov 17, 2023
17 checks passed
@oschusler oschusler deleted the 12-set-up-github-actions branch November 17, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up GitHub actions
3 participants