Add rtscts keyword to TransportDescriptorParser #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test assumed rtscts would be False, but it's actualy always set to True in Thorlabs_MFF10X.__init__(). It just wasn't used because the parser didn't support the rtscts keyword up to now.
heevasti
reviewed
Oct 10, 2024
heevasti
reviewed
Oct 10, 2024
heevasti
approved these changes
Oct 10, 2024
pieterbuzing
deleted the
105-serial-transport-descriptor-missing-rtscts-definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a proper case for bool type in the parser (otherwise any non-empty string would evaluate to True).