Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

107 remove python 38 support #110

Merged
merged 3 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
max-parallel: 3
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]

uses: ./.github/workflows/reusable-ci-workflows.yml
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scheduled-full-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]

uses: ./.github/workflows/reusable-ci-workflows.yml
with:
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sphinx:
build:
os: ubuntu-22.04
tools:
python: "3.8"
python: "3.9"

python:
install:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

### Removed
- Python 3.8 support, numpy and scipy version restrictions in dependencies.


## [0.46.0] - 2024-10-14
Expand Down
4 changes: 2 additions & 2 deletions TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ In any case, both tools can be run from the command line:
Unit tests
----------

Unit tests are executed in the CI environment against different Python versions: 3.8, 3.9 and 3.10. Code coverage of
Unit tests are executed in the CI environment against different Python versions: 3.9 and 3.10. Code coverage of
the tests is computed using [Coverage.py](https://coverage.readthedocs.io/en/coverage-5.3.1/). To run the tests
locally, use:
```zsh
Expand All @@ -53,7 +53,7 @@ In the first three workflows, the following tests are performed:
- The code quality and maintainability analyses and unit-test coverage are performed, as these metrics are considered as quality indicators for the code base (which includes
tests).
- Unit-tests are performed and the coverage is calculated.
- On push to a branch, tests are executing only with Python 3.11. When changes are pushed to a pull request, the tests are rerun parallel also with Python 3.8, 3.9 and 3.10. With the 3.10 version, the quality badges are created.
- On push to a branch, tests are executing only with Python 3.11. When changes are pushed to a pull request, the tests are rerun parallel also with Python 3.9 and 3.10. With the 3.10 version, the quality badges are created.

The fourth workflow packages the source code into an installable Python package.

Expand Down
2 changes: 1 addition & 1 deletion documentation/sphinx/source/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Dependencies

.. rubric:: Python version

QMI depends on Python 3.8 or newer.
QMI depends on Python 3.9 or newer.

.. rubric:: Python packages

Expand Down
11 changes: 5 additions & 6 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def read(*names, **kwargs):
name="qmi",
version="0.47.0-beta.0",
description="The Quantum Measurement Infrastructure framework",
long_description="{}\n".format(read('README.md')),
long_description_content_type='text/markdown',
long_description="{}\n".format(read("README.md")),
long_description_content_type="text/markdown",
author="QuTech",
author_email="",
url="https://github.com/QuTech-Delft/QMI",
Expand All @@ -35,7 +35,6 @@ def read(*names, **kwargs):
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -50,15 +49,15 @@ def read(*names, **kwargs):
keywords=[
# eg: 'keyword1', 'keyword2', 'keyword3',
],
python_requires=">=3.8, <4",
python_requires=">=3.9, <4",
install_requires=[
# For generating an installable package and deploying
"setuptools",
"wheel",
"twine",
# For scientific data processing and visualisation
"numpy<2",
"scipy<2",
"numpy",
"scipy",
"h5py>=3.7.0",
# For hardware interfacing
"pyserial",
Expand Down