Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

62 new qmi driver for thorlabs mpc320 #73

Merged
merged 41 commits into from
Jul 16, 2024
Merged

62 new qmi driver for thorlabs mpc320 #73

merged 41 commits into from
Jul 16, 2024

Conversation

rbudhrani
Copy link
Collaborator

No description provided.

@rbudhrani rbudhrani linked an issue Mar 15, 2024 that may be closed by this pull request
New QMI driver for Thorlabs MPC320 #62
Closed
Badge Bot and others added 3 commits March 15, 2024 18:12
@rbudhrani rbudhrani marked this pull request as draft March 18, 2024 10:23
@rbudhrani rbudhrani self-assigned this Mar 18, 2024
@rbudhrani rbudhrani added the blocked An issue is blocked by another issue label Apr 2, 2024
@rbudhrani rbudhrani removed the blocked An issue is blocked by another issue label Jul 12, 2024
heevasti
heevasti reviewed Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@heevasti heevasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here! Some comments and questions. Don't forget to add the shortcut to the class in __init__.py and edit the CHANGELOG.md. Awaiting for the unit-tests.

The protocol seems fine to me in general.

qmi/instruments/thorlabs/apt_packets.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/mpc320.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/mpc320.py Show resolved Hide resolved
qmi/instruments/thorlabs/apt_protocol.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/apt_protocol.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/mpc320.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/mpc320.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/mpc320.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/mpc320.py Outdated Show resolved Hide resolved
qmi/instruments/thorlabs/mpc320.py Show resolved Hide resolved
@rbudhrani rbudhrani marked this pull request as ready for review July 16, 2024 08:41
@rbudhrani rbudhrani merged commit aed1222 into main Jul 16, 2024
5 checks passed
@rbudhrani rbudhrani deleted the 62-new-qmi-driver-for-thorlabs-mpc320 branch July 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heevasti heevasti heevasti approved these changes

Assignees

@rbudhrani rbudhrani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New QMI driver for Thorlabs MPC320
2 participants
@rbudhrani @heevasti