90 add enter and exit methods to qmi instrument #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QMI_Instrument
andQMI_TaskRunner
(which inherit fromQMI_RpcObject
) are now equipped with specific__enter__
and__exit__
methods, which in the case ofQMI_Instrument
also open and close the instrument when run with a
with
context manager protocol. MeanwhileQMI_TaskRunner
starts and stops then joins a QMI task thread. In practise, these context managerscan be used instead of the to-be-obsoleted
open_close
andstart_stop_join
context managers. The context manager protocol cannot be used forQMI_RpcObject
directly.Relevant unit-tests added
Docstrings added and improved.
Fix on scheduled full CI unit-test pipeline which was missing installing of dependencies.