90 add enter and exit methods to qmi instrument #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2024 10:14
…strument` and `QMI_TaskRunner` classes, which inherit from `QMI_RpcProxy`. The latter has also now the same methods implemented but not as RPC methods. Added warnings of obsoletion into `open_close` and `start_stop_join` context managers in `qmi.utils.context_managers`. Added unit-tests, and added and improved docstrings.
pieterjbotma
approved these changes
Aug 26, 2024
heevasti
deleted the
90-add-__enter__-and-__exit__-methods-to-qmi_instrument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QMI_InstrumentandQMI_TaskRunner(which inherit fromQMI_RpcObject) are now equipped with specific__enter__and__exit__methods, which in the case ofQMI_Instrumentalso open and close the instrument when run with a
withcontext manager protocol. MeanwhileQMI_TaskRunnerstarts and stops then joins a QMI task thread. In practise, these context managerscan be used instead of the to-be-obsoleted
open_closeandstart_stop_joincontext managers. The context manager protocol cannot be used forQMI_RpcObjectdirectly.Relevant unit-tests added
Docstrings added and improved.
Fix on scheduled full CI unit-test pipeline which was missing installing of dependencies.