Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QI2-1122] Added compiler_config for compilation stages #10

Closed

Conversation

NischalQuTech
Copy link
Contributor

No description provided.

@NischalQuTech NischalQuTech requested a review from a team as a code owner October 28, 2024 14:23
@NischalQuTech NischalQuTech force-pushed the feature/QI2-1122/Determine_configuration_format branch from f76df66 to a80214e Compare October 28, 2024 14:26
@oschusler oschusler marked this pull request as draft October 28, 2024 20:21
@@ -42,14 +42,62 @@
"description": "Timestamp of start-up of the system (return value of time.time())",
"title": "Starttime",
"type": "number"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schemas are automatically generated from the pydantic models in the platform. Arguably, we should describe the format in the markdown files. They are a bit more readable, and not auto-generated.

That being said, am I right in understanding that this would translate to something like:

[
    {
        "compiler_stage": "mapped",
        "compiler_passes": [
            {
                "decomposer": "MckayDecomposer",
                "merge_single_qubit_gates": true
            }
        ]
    }
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit hesitant to divide the compiler passes up into stages right now. Why not just a flat list of passes? Especially since we know that the current categorization doesn't make sense for QI (scheduled is not a part of OpenSquirrel, and routing is missing).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, doesn't this schema enforce that every pass is a decomposer? Why not something a bit more generic like:

{
    "compiler_passes": [ 
        { 
            "name": "MckayDecomposer", 
            "arguments": {
                "merge_single_qubit_gates": true 
            }
        } ]
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants