Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romanian language added. #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Romanian language added. #4

wants to merge 3 commits into from

Conversation

tommyomw
Copy link

No description provided.

@tommyomw
Copy link
Author

Hi,
I've added the Romanian translation.
Hope this is ok.

@ztheory
Copy link
Collaborator

ztheory commented Feb 10, 2025

Thank you for this translation; this is a lot of work.

A few things preventing pulling this:

  1. The top-level folder should be docs/ro, not docs/ro/ro
  2. All files (articles) must be matching, so that means changing from Encrypted to Criptat, such as the Android and MacOS articles.
  3. The menu items have not been translated in the articles. For example, in the Windows 10 article:
    * Selectați `Use the following DNS server addresses`.
    Needs to be replaced with what Windows actually shows in the Romanian version of Windows 10. Probably best to start with the operating systems you use, since you can quickly check the names of those options/text.

The menu items in .3 explained above are difficult, since each operating system can have slightly different terms depending on who translated them. We can still merge this pull request even if all articles don't have the translated menu items; we will just need to print a disclaimer at the top mentioning this is a community translation that is incomplete, and we can make an issue for it in GitHub and compete those later.

@tommyomw
Copy link
Author

tommyomw commented Feb 10, 2025 via email

@tommyomw tommyomw closed this Feb 10, 2025
@tommyomw tommyomw reopened this Feb 10, 2025
@tommyomw
Copy link
Author

Does it work now?
Changes have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants