Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Anthropic assistants #380

Conversation

smokestacklightnin
Copy link
Contributor

@smokestacklightnin smokestacklightnin commented Mar 31, 2024

This PR addresses Issue #347

Support (in Ragna) is changed from legacy (Chat API)or unsupported (by Anthropic) models to the Anthropic Messages API.

IMPORTANT: This PR should be merged before PR #381 and PR #376 are merged.

@smokestacklightnin smokestacklightnin linked an issue Mar 31, 2024 that may be closed by this pull request
@smokestacklightnin smokestacklightnin marked this pull request as ready for review March 31, 2024 07:56
@smokestacklightnin smokestacklightnin self-assigned this Mar 31, 2024
In the original order, some conditionals would never run

Also clean up breakpoint
ragna/assistants/_anthropic.py Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done. Just a few suggestions on how to improve the system prompt generation.

ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
ragna/assistants/_anthropic.py Outdated Show resolved Hide resolved
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks William!

@pmeier
Copy link
Member

pmeier commented Apr 8, 2024

Test failures are unrelated.

@pmeier pmeier merged commit f7de2e9 into Quansight:main Apr 8, 2024
6 of 10 checks passed
@smokestacklightnin smokestacklightnin deleted the assistants/anthropic/update-anthropic-assistants branch January 6, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Anthropic assistants
2 participants