-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Anthropic assistants #380
Merged
pmeier
merged 16 commits into
Quansight:main
from
smokestacklightnin:assistants/anthropic/update-anthropic-assistants
Apr 8, 2024
Merged
Update Anthropic assistants #380
pmeier
merged 16 commits into
Quansight:main
from
smokestacklightnin:assistants/anthropic/update-anthropic-assistants
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove old unsupported or legacy assistants or API calls.
In the original order, some conditionals would never run Also clean up breakpoint
This was referenced Apr 2, 2024
pmeier
requested changes
Apr 2, 2024
Also improve system prompt according to tips from the Anthropic documentation
pmeier
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done. Just a few suggestions on how to improve the system prompt generation.
pmeier
reviewed
Apr 7, 2024
pmeier
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks William!
Test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #347
Support (in Ragna) is changed from legacy (Chat API)or unsupported (by Anthropic) models to the Anthropic Messages API.
IMPORTANT: This PR should be merged before PR #381 and PR #376 are merged.