-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to panel==1.4.4 #452
Conversation
@pmeier Am I supposed to update requirements-docker.toml manually or let CI do it? I tried both ways and it's angry either way. |
Hi @blakerosenthal, apparantly if you run locally - pip-compile --quiet --strip-extras --output-file=requirements-docker.lock --extra=all pyproject.toml It should do it, but I wouldn't recommend that because of the difference in environments on CI & locally. Until now I did some workaround for that in arjxn-py/ragna#3 (See |
No, this is a valid way to do it. The only thing that one needs consider is that our default dev env runs on Lines 4 to 5 in 55f7fc5
while the docker images uses Line 1 in 55f7fc5
Thus, the command should be run from Python 3.11.
Yeah, I imagined the workflow to just merge a PR like this as is and let the bot send a follow-up PR. This what I propose we do here to avoid blocking the PR. @arjxn-py I saw refactored it so that the bot automatically pushes a commit to PR branch. I dislike this workflow, because it can mess up the branch I have locally. I don't think it is too bad here given that this file shouldn't be touched manually anyway, but I still have my concerns. If you want to have a different workflow, feel free to open a discussion issue. Maybe we can just go for a middle ground and let the bot run on every push to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Blake!
I could not find any visible side-by-side differences between panel 1.4.2 and 1.4.4. The file selector popup feels noticeably faster in 1.4.4 though! I did find a couple quirky UI issues that are ragna problems, not panel problems, and I will open separate issues for these.
Closes #451