Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to panel==1.4.4 #452

Merged
merged 2 commits into from
Jul 22, 2024
Merged

update to panel==1.4.4 #452

merged 2 commits into from
Jul 22, 2024

Conversation

blakerosenthal
Copy link
Contributor

I could not find any visible side-by-side differences between panel 1.4.2 and 1.4.4. The file selector popup feels noticeably faster in 1.4.4 though! I did find a couple quirky UI issues that are ragna problems, not panel problems, and I will open separate issues for these.

Closes #451

@blakerosenthal
Copy link
Contributor Author

@pmeier Am I supposed to update requirements-docker.toml manually or let CI do it? I tried both ways and it's angry either way.

@arjxn-py
Copy link
Contributor

Hi @blakerosenthal, apparantly if you run locally -

pip-compile --quiet --strip-extras --output-file=requirements-docker.lock --extra=all pyproject.toml

It should do it, but I wouldn't recommend that because of the difference in environments on CI & locally.

Until now docker-requirements / update (pull_request) job is just testing if current requirements-docker.lock matches the output of the above command and instead of updating it automatically for you it fails. Because the workflow is supposed to open a separate PR & only if it's manually triggered.

I did some workaround for that in arjxn-py/ragna#3 (See b60ca7a is auto-generated), please have a look.

@pmeier
Copy link
Member

pmeier commented Jul 22, 2024

It should do it, but I wouldn't recommend that because of the difference in environments on CI & locally.

No, this is a valid way to do it. The only thing that one needs consider is that our default dev env runs on

dependencies:
- python =3.9

while the docker images uses

FROM python:3.11

Thus, the command should be run from Python 3.11.

Until now docker-requirements / update (pull_request) job is just testing if current requirements-docker.lock matches the output of the above command and instead of updating it automatically for you it fails. Because the workflow is supposed to open a separate PR & only if it's manually triggered.

Yeah, I imagined the workflow to just merge a PR like this as is and let the bot send a follow-up PR. This what I propose we do here to avoid blocking the PR.

@arjxn-py I saw refactored it so that the bot automatically pushes a commit to PR branch. I dislike this workflow, because it can mess up the branch I have locally. I don't think it is too bad here given that this file shouldn't be touched manually anyway, but I still have my concerns. If you want to have a different workflow, feel free to open a discussion issue. Maybe we can just go for a middle ground and let the bot run on every push to main and automatically send a PR if necessary rather than us starting the workflow manually?

Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Blake!

@pmeier pmeier merged commit 75c5499 into main Jul 22, 2024
22 of 23 checks passed
@pmeier pmeier deleted the panel-update branch July 22, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update panel to 1.4.4
3 participants