Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy refactor #509

Merged
merged 36 commits into from
Dec 12, 2024
Merged

deploy refactor #509

merged 36 commits into from
Dec 12, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Dec 11, 2024

No description provided.

@pmeier pmeier marked this pull request as ready for review December 11, 2024 14:56
@pmeier
Copy link
Member Author

pmeier commented Dec 11, 2024

As of ac13a3c this PR is mostly feature complete. All individual features have been reviewed in the respective PRs. Thus, the only thing left here is cleanup

  • fix documentation
  • checkout testing segfault on 3.11 and 3.12
    • Report segfault to pymupdf for >= 1.24.10
  • checkout CI failure on Windows
  • re-enable and fix UI tests
  • fix styling on file input widget
  • add a profile page with API key generation
  • write tutorial for authentication
  • add API documentation for authentication
  • style username / password auth page
  • replace api_wrapper inside the UI with directly calling the engine

Not everything from the list above has to be implemented as part of this PR and can be done in follow-ups.

@pmeier
Copy link
Member Author

pmeier commented Dec 12, 2024

Build on RTD fails with

WARNING: Built wheel for Ragna is invalid: Wheel has unexpected file name: expected '0.3.0.dev58+g0d1e09b.d20241212103454', got '0.3.0.dev58+g0d1e09b.d20241212103509'

If I see this right it complains about dirty timestamp mismatch. I'm guessing this is fallout from pypa/setuptools-scm#962.

@pmeier
Copy link
Member Author

pmeier commented Dec 12, 2024

I think the Windows CI failure happens because the

mamba env update --file environment-dev.yml

call seems to not work properly and even corrupt the env somehow. We only get the following output from the command

Microsoft Windows [Version 10.0.20348.2849]
(c) Microsoft Corporation. All rights reserved.
D:\a\ragna\ragna>

and after that although the environment should be activated, the system Python is used. And that finally leads to the failures.

@pmeier pmeier merged commit acb5fed into main Dec 12, 2024
9 of 11 checks passed
@pmeier pmeier deleted the deploy-dev branch December 12, 2024 15:03
@pmeier pmeier mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant