refactor: return always 'true' from PlaceOrder to handle Invalid Orde…

…r internally in brokerage (#17)
QuantConnect · Sep 11, 2024 · f691001 · f691001
1 parent 7ed3f3f
commit f691001
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/QuantConnect.AlpacaBrokerage/AlpacaBrokerage.cs b/QuantConnect.AlpacaBrokerage/AlpacaBrokerage.cs
@@ -342,7 +342,6 @@ public override bool PlaceOrder(Order order)
                 return false;
             }
 
-            var result = false;
             try
             {
                 _messageHandler.WithLockedStream(() =>
@@ -361,20 +360,14 @@ public override bool PlaceOrder(Order order)
                         order.BrokerId.Add(response.OrderId.ToString());
 
                         OnOrderEvent(new OrderEvent(order, DateTime.UtcNow, OrderFee.Zero, $"{nameof(AlpacaBrokerage)} Order Event") { Status = Orders.OrderStatus.Submitted });
-                        result = response != null && response.OrderStatus != AlpacaMarket.OrderStatus.Rejected;
-                    }
-                    else
-                    {
-                        result = isPlaceCrossOrder.Value;
                     }
                 });
             }
             catch (Exception ex)
             {
                 OnOrderEvent(new OrderEvent(order, DateTime.UtcNow, OrderFee.Zero, ex.Message) { Status = Orders.OrderStatus.Invalid });
             }
-
-            return result;
+            return true;
         }
 
         private void HandleTradeUpdate(ITradeUpdate obj)