-
-
Notifications
You must be signed in to change notification settings - Fork 53
von Neumann lecture improvements #478 #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Set the max-height of cells to none - Removed `object` after `class Nuemann` - Adopted `sphinx-proof` enviornments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the von Neumann lecture by modernizing documentation formatting and fixing minor inconsistencies. The changes primarily focus on adopting sphinx-proof
environments for better mathematical presentation and updating code cell configurations.
Key changes:
- Adoption of
sphinx-proof
environments for assumptions, definitions, theorems, and proofs - Removal of
object
inheritance fromclass Neumann
(Python 3 style) - Addition of CSS styling to remove cell height restrictions
Assumptions: | ||
- AI: every column of B has a positive entry : {AI} | ||
- AII: every row of A has a positive entry : {AII} | ||
Assumptions:// TODO:change {AI} variable into A1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO comment should be removed or properly formatted. If this is a genuine TODO, it should be tracked in an issue rather than left in production code.
Assumptions:// TODO:change {AI} variable into A1? | |
Assumptions: |
Copilot uses AI. Check for mistakes.
@@ -372,18 +382,20 @@ an economy. | |||
|
|||
Two key assumptions restrict economy $(A,B)$: | |||
|
|||
- **Assumption I:** (every good that is consumed is also produced) | |||
````{prf:assumption} every good that is consumed is also produced) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra closing parenthesis in the assumption title. It should be 'every good that is consumed is also produced' without the trailing parenthesis.
````{prf:assumption} every good that is consumed is also produced) | |
````{prf:assumption} every good that is consumed is also produced |
Copilot uses AI. Check for mistakes.
Thanks for the PR @xuanguang-li. I will take a look tomorrow. |
Key changes
object
afterclass Nuemann
sphinx-proof
environmentsQuestion
sphinx-proof
, assumptions numbered as "I, II" have been changed to "1, 2". But in the definition ofclass Neumann
, some variables are named asAI
andAII
. Should I change the names of these variables toA1
andA2
? @mmckyFor example,