Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onclick #35

Merged
merged 7 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ instance/

# Sphinx documentation
docs/_build/
docs/_static/
docs/source/_static/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docs/source/_static/
docs/_static/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is docs/source/_static/ the path that I get when I build the project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are not located in docs/source anymore, are you sure you ran the docs build from the latest version?

Copy link
Contributor Author

@Nour-Cheour10 Nour-Cheour10 Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,well the docs are not located in docs/source but the files I get out of the build are
Screenshot from 2024-08-27 16-21-53

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thanks, I'll get it done.

docs/_static/embed-bundle.js
docs/_static/embed-bundle.js.map
docs/build
Expand Down Expand Up @@ -133,6 +133,8 @@ ehthumbs.db
# Folder config file
Desktop.ini
.config.ini
.env.ini


# Recycle Bin used on file shares
$RECYCLE.BIN/
Expand Down
2 changes: 1 addition & 1 deletion examples/GeojsonLayer.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.19"
"version": "3.12.4"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion examples/RasterLayer.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.19"
"version": "3.12.4"
}
},
"nbformat": 4,
Expand Down
56 changes: 50 additions & 6 deletions examples/map.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
{
"cell_type": "code",
"execution_count": 1,
"execution_count": 7,
"id": "94284d6e",
"metadata": {
"vscode": {
Expand All @@ -21,15 +21,15 @@
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "cf72e462ac2847b586c82d5738e01598",
"model_id": "2fe473c94493460082701df614ff2268",
"version_major": 2,
"version_minor": 0
},
"text/plain": [
"Map(center=[0.0, 0.0], layers=[RasterTileLayer()])"
"Map(center=[0.0, 0.0], zoom=2.0)"
]
},
"execution_count": 1,
"execution_count": 7,
"metadata": {},
"output_type": "execute_result"
}
Expand All @@ -38,6 +38,10 @@
"from ipyopenlayers import (\n",
" Map, RasterTileLayer\n",
")\n",
"import configparser\n",
"import requests\n",
"import unicodedata\n",
"\n",
"m = Map(center=[0.0, 0.0], zoom=2)\n",
"layer= RasterTileLayer()\n",
"m.add_layer(layer)\n",
Expand All @@ -46,10 +50,50 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 8,
"id": "6ecd0ff6-93f3-4cd8-bc0a-8520aab07a84",
"metadata": {},
"outputs": [],
"source": [
"config = configparser.ConfigParser()\n",
"config.read('../.env.ini')\n",
"api_key = config['DEFAULT']['api_key']"
]
},
{
"cell_type": "code",
"execution_count": 9,
"id": "c2a997b5-3f80-4e9c-8956-5dba704f7eae",
"metadata": {},
"outputs": [],
"source": [
"def get_country_from_coordinates_geoapify(**kwargs):\n",
" lon = kwargs.get('lon')\n",
" lat = kwargs.get('lat')\n",
" url = f\"https://api.geoapify.com/v1/geocode/reverse?lat={lat}&lon={lon}&apiKey={api_key}\"\n",
" \n",
" response = requests.get(url)\n",
" data = response.json()\n",
" \n",
" features = data.get('features', [])\n",
" if features:\n",
" first_feature = features[0]\n",
" properties = first_feature.get('properties', {})\n",
" country = properties.get('country', None)\n",
" normalized_name = country.split(' ')[0]\n",
" normalized_name = unicodedata.normalize('NFKD', normalized_name)\n",
" normalized_name = normalized_name.encode('ASCII', 'ignore').decode('utf-8')\n",
" print(f\"Country: {normalized_name}\")\n",
"\n",
"m.on_click(get_country_from_coordinates_geoapify)"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "73641754-d12e-41b6-8257-f43376ae18ec",
"metadata": {},
"outputs": [],
"source": []
}
],
Expand All @@ -69,7 +113,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.19"
"version": "3.12.4"
}
},
"nbformat": 4,
Expand Down
24 changes: 21 additions & 3 deletions ipyopenlayers/openlayers.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Copyright (c) QuantStack.
# Distributed under the terms of the Modified BSD License.

from ipywidgets import DOMWidget, Widget, widget_serialization
from ipywidgets import DOMWidget, Widget, widget_serialization, CallbackDispatcher
from traitlets import Unicode, List, Instance, CFloat, Bool, Dict, Int, Float
from ._frontend import module_name, module_version

Expand Down Expand Up @@ -43,7 +43,7 @@ class TileLayer(Layer):
Additional format options for the tile source.
"""

url = Unicode('').tag(sync=True)
url = Unicode('https://{a-c}.tile.openstreetmap.org/{z}/{x}/{y}.png').tag(sync=True)
attribution = Unicode("").tag(sync=True)
opacity = Float(1.0, min=0.0, max=1.0).tag(sync=True)
visible = Bool(True).tag(sync=True)
Expand Down Expand Up @@ -263,6 +263,8 @@ class Map(DOMWidget):
layers = List(Instance(Layer)).tag(sync=True, **widget_serialization)
overlays=List(Instance(BaseOverlay)).tag(sync=True, **widget_serialization)
controls=List(Instance(BaseControl)).tag(sync=True, **widget_serialization)
_click_callbacks = Instance(CallbackDispatcher, ())




Expand All @@ -277,6 +279,7 @@ def __init__(self, center=None, zoom=None, **kwargs):
The initial zoom level of the map.
"""
super().__init__(**kwargs)
self.on_msg(self._handle_mouse_events)
if center is not None:
self.center = center
if zoom is not None:
Expand Down Expand Up @@ -351,4 +354,19 @@ def clear_layers(self):
"""Remove all layers from the map.

"""
self.layers = []
self.layers = []

def _handle_mouse_events(self, _, content, buffers):
"""Handle mouse events and trigger click callbacks.
"""
event_type = content.get("type", "")
if event_type == "click":
self._click_callbacks(**content)

def on_click(self, callback, remove=False):
"""Add a click event listener.
"""
self._click_callbacks.register_callback(callback, remove=remove)



11 changes: 11 additions & 0 deletions src/widget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { BaseOverlayModel, BaseOverlayView } from './baseoverlay';
import { BaseControlModel, BaseControlView } from './basecontrol';
import { ViewObjectEventTypes } from 'ol/View';
import TileLayer from 'ol/layer/Tile';
import MapBrowserEvent from 'ol/MapBrowserEvent';
import { Map } from 'ol';
import View from 'ol/View';
import 'ol/ol.css';
Expand Down Expand Up @@ -122,6 +123,10 @@ export class MapView extends DOMWidgetView {
],
});

this.map.on('click', (event: MapBrowserEvent<MouseEvent>) => {
this.handleMapClick(event);
});

this.map.getView().on('change:center', () => {
this.model.set('center', this.map.getView().getCenter());
this.model.save_changes();
Expand All @@ -143,6 +148,12 @@ export class MapView extends DOMWidgetView {
this.model.on('change:zoom', this.zoomChanged, this);
this.model.on('change:center', this.centerChanged, this);
}

handleMapClick(event: MapBrowserEvent<MouseEvent>) {
const coordinate = event.coordinate;
const [lon, lat] = coordinate;
this.send({ type: 'click', lon, lat });
}
layersChanged() {
const layers = this.model.get('layers') as LayerModel[];
this.layerViews.update(layers);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading