-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up backend content manager #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er for frontend requests
afshin
reviewed
Nov 19, 2024
afshin
reviewed
Nov 19, 2024
afshin
reviewed
Nov 19, 2024
afshin
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Afshin Taylor Darian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the backend manager. The logic to transition to one provider independent manager was added, by modifying the already existing
JupyterDrivesManager
class. To achieve this, the architecture for theentrypoints
was modified, as we only need to register one manager for all providers now.The listing drives functionality was updated to have the provider independent set up.
The
mount_drive
functionality was added in the backend and its corresponding frontend request. It is meant to be used when first accessing a drive, in order to create the content manager/store for it in the backend. Consequently, themounted
property was added toIDriveInfo
interface to signal whether a content manager was already set up in the backend for the specific drive.Also, switched to the use of the
obstore
package for the backend.