Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up backend content manager #23

Merged
merged 16 commits into from
Nov 19, 2024
Merged

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Nov 14, 2024

This PR sets up the backend manager. The logic to transition to one provider independent manager was added, by modifying the already existing JupyterDrivesManager class. To achieve this, the architecture for the entrypoints was modified, as we only need to register one manager for all providers now.

The listing drives functionality was updated to have the provider independent set up.

The mount_drive functionality was added in the backend and its corresponding frontend request. It is meant to be used when first accessing a drive, in order to create the content manager/store for it in the backend. Consequently, the mounted property was added to IDriveInfo interface to signal whether a content manager was already set up in the backend for the specific drive.

Also, switched to the use of the obstore package for the backend.

@DenisaCG DenisaCG added the enhancement New feature or request label Nov 14, 2024
@DenisaCG DenisaCG self-assigned this Nov 14, 2024
Copy link

Binder 👈 Launch a Binder on branch DenisaCG/jupyter-drives/contentsManager

jupyter_drives/base.py Outdated Show resolved Hide resolved
jupyter_drives/manager.py Outdated Show resolved Hide resolved
jupyter_drives/manager.py Outdated Show resolved Hide resolved
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DenisaCG DenisaCG merged commit 11585dc into QuantStack:main Nov 19, 2024
6 checks passed
@DenisaCG DenisaCG deleted the contentsManager branch November 19, 2024 11:49
@DenisaCG DenisaCG restored the contentsManager branch November 19, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants