Merge branch 'develop' into feature/getVariableCategoryName

QuantiModo · Sep 17, 2020 · 8d0c0f6 · 8d0c0f6 · mikepsinn · Sep 17, 2020
2 parents a26a1cc + edeed75
commit 8d0c0f6
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 63 deletions.
diff --git a/.idea/runConfigurations/GI_Test.xml b/.idea/runConfigurations/GI_Test.xml
diff --git a/.idea/runConfigurations/GI_Test_API_Suite.xml b/.idea/runConfigurations/GI_Test_API_Suite.xml
diff --git a/.idea/runConfigurations/GI_Test_Ionic_Suite.xml b/.idea/runConfigurations/GI_Test_Ionic_Suite.xml
diff --git a/.idea/runConfigurations/ionic_pull.xml b/.idea/runConfigurations/ionic_pull.xml
diff --git a/src/js/qmHelpers.js b/src/js/qmHelpers.js
@@ -4388,10 +4388,10 @@ var qm = {
                     qm.qmLog.errorAndExceptionTestingOrDevelopment("Could not get unit for this measurement: ", m)
                 } else {
                     if(!m.unitAbbreviatedName){m.unitAbbreviatedName = unit.abbreviatedName;}
+                    if(unit.abbreviatedName === '/5'){m.roundedValue = Math.round(m.value);}
                 }
                 if(!m.variableName){m.variableName = m.variable;}
                 if(m.variableName === qm.getPrimaryOutcomeVariable().name){m.valence = qm.getPrimaryOutcomeVariable().valence;}
-                if(unit.abbreviatedName === '/5'){m.roundedValue = Math.round(m.value);}
                 m.displayValueAndUnitString = m.displayValueAndUnitString || m.value + " " + unit.abbreviatedName;
                 m.displayValueAndUnitString = qm.stringHelper.formatValueUnitDisplayText(m.displayValueAndUnitString)
                 m.valueUnitVariableName = m.displayValueAndUnitString + " " + m.variableName;

diff --git a/src/js/services/qmService.js b/src/js/services/qmService.js
@@ -2877,8 +2877,10 @@ angular.module('starter').factory('qmService', ["$http", "$q", "$rootScope", "$i
                                         if(!notificationExists && queue[0].reminderFrequency && !queue[0].stopTrackingDate){
                                             qmLog.error("Notification not found for reminder we just created!", null, {'reminder': queue[0]});
                                         }
-                                        qmLog.info("Got " + notifications.length + " notifications to from postTrackingRemindersDeferred response", null, {notifications: notifications});
-                                        qm.storage.setTrackingReminderNotifications(notifications);
+                                        qmLog.info("Got " + notifications.length +
+                                            " notifications to from postTrackingRemindersDeferred response",
+                                            null, {notifications: notifications});
+                                        putTrackingReminderNotificationsInLocalStorageAndUpdateInbox(notifications);
                                     }
                                 }else{
                                     qmLog.error("No postTrackingRemindersToApi response.data!");