Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat faces as buttons instead of images on mobile #3607

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mikepsinn
Copy link
Contributor

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

ng-click="track(trackingReminderNotification, option.numericValue, $event)" ng-src="{{option.img}}">
ng-click="track(trackingReminderNotification, option.numericValue, $event)">
<img ng-src="{{option.img}}"
style="width: 100%;">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

on-hold="trackAllWithConfirmation(trackingReminderNotification, option.numericValue, $event)"
ng-click="track(trackingReminderNotification, option.numericValue, $event)">
<img ng-src="{{option.img}}"
style="width: 100%;">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

on-hold="trackAllWithConfirmation(trackingReminderNotification, option.numericValue, $event)"
ng-click="track(trackingReminderNotification, option.numericValue, $event)">
<img ng-src="{{option.img}}"
style="width: 100%;">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@mikepsinn mikepsinn temporarily deployed to medimodo May 16, 2019 02:47 Inactive
@mikepsinn mikepsinn temporarily deployed to medimodo July 22, 2019 01:32 Inactive
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

ng-src="{{option.img}}"></div>
<div class="primary-outcome-variable-rating-buttons">
<button ng-repeat="option in numericRatingOptions" ng-click="track(trackingReminderNotification, option.numericValue, $event)">
<img ng-src="{{option.img}}">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)"
ng-src="{{option.img}}">
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)">
<img ng-src="{{option.img}}">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

ng-src="{{option.img}}"> <br></div>
<div class="primary-outcome-variable-rating-buttons">
<button ng-repeat="option in positiveRatingOptions" ng-click="track(trackingReminderNotification, option.numericValue, $event)">
<img ng-src="{{option.img}}">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)"
ng-src="{{option.img}}">
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)">
<img ng-src="{{option.img}}">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

ng-src="{{option.img}}"> <br></div>
<div class="primary-outcome-variable-rating-buttons">
<button ng-repeat="option in negativeRatingOptions" ng-click="track(trackingReminderNotification, option.numericValue, $event)">
<img ng-src="{{option.img}}">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)"
ng-src="{{option.img}}">
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)">
<img ng-src="{{option.img}}">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@mikepsinn mikepsinn temporarily deployed to medimodo August 7, 2019 00:38 Inactive
@mikepsinn mikepsinn temporarily deployed to medimodo August 8, 2019 13:50 Inactive
@mikepsinn mikepsinn temporarily deployed to medimodo August 8, 2019 15:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant