-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat faces as buttons instead of images on mobile #3607
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
ng-click="track(trackingReminderNotification, option.numericValue, $event)" ng-src="{{option.img}}"> | ||
ng-click="track(trackingReminderNotification, option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}" | ||
style="width: 100%;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
on-hold="trackAllWithConfirmation(trackingReminderNotification, option.numericValue, $event)" | ||
ng-click="track(trackingReminderNotification, option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}" | ||
style="width: 100%;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
on-hold="trackAllWithConfirmation(trackingReminderNotification, option.numericValue, $event)" | ||
ng-click="track(trackingReminderNotification, option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}" | ||
style="width: 100%;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
ng-src="{{option.img}}"></div> | ||
<div class="primary-outcome-variable-rating-buttons"> | ||
<button ng-repeat="option in numericRatingOptions" ng-click="track(trackingReminderNotification, option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)" | ||
ng-src="{{option.img}}"> | ||
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
ng-src="{{option.img}}"> <br></div> | ||
<div class="primary-outcome-variable-rating-buttons"> | ||
<button ng-repeat="option in positiveRatingOptions" ng-click="track(trackingReminderNotification, option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)" | ||
ng-src="{{option.img}}"> | ||
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
ng-src="{{option.img}}"> <br></div> | ||
<div class="primary-outcome-variable-rating-buttons"> | ||
<button ng-repeat="option in negativeRatingOptions" ng-click="track(trackingReminderNotification, option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)" | ||
ng-src="{{option.img}}"> | ||
ng-click="track(trackingReminderNotifications[0], option.numericValue, $event)"> | ||
<img ng-src="{{option.img}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
No description provided.