Incorrect block producer address #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khssnv
requested changes
Sep 5, 2025
Member
There was a problem hiding this comment.
Please check the upstream project file. Seems like we may leave minimal changes in this and put SPIN-specific logic somewhere else to simplify new upstream versions merge later.
khssnv
reviewed
Sep 8, 2025
| const { api } = useApi(); | ||
|
|
||
| useEffect(() => { | ||
| const loadAuxData = async () => { |
Member
There was a problem hiding this comment.
Redundant function definition? Can we put loadAuxData body into the outer function?
Collaborator
Author
There was a problem hiding this comment.
useEffect callback cannot be async directly, that’s why I wrapped it.
| } | ||
|
|
||
| return null; | ||
| return undefined; |
Collaborator
Author
There was a problem hiding this comment.
You’re right, this change was unnecessary. Returning null was correct in this case.
Vsevolod-Rusinskiy
force-pushed
the
vsevolod/incorrect-block-producer-address
branch
from
55b69a9 to
8da3f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
auxDatacall in a dedicateduseEffectto avoid redundant requests.Result
Related to QuantumFusion-network/spec#363.