Skip to content

Updated dependencies #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated dependencies #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions annotationprocessor/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ buildscript {
repositories{
jcenter()
}
dependencies {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be needed for the code generation phase. but I have no idea.
Test things out with the example project. Change some variables around and see if the auto generation works.

classpath 'com.squareup:javapoet:1.9.0'
}
}

group='com.github.quarkworks' // jitpack.io
Expand All @@ -19,15 +16,15 @@ def source_GIT_COMMIT = new File(buildDir, 'generated/source/GIT_COMMIT/main/jav
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])

implementation "org.jetbrains.kotlin:kotlin-stdlib-jre8:$kotlin_version"
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"

implementation project(':annotations')
implementation "io.realm:realm-annotations:$realm_version"

kapt "com.google.auto.service:auto-service:1.0-rc2" // don't update yet, won't auto generate code
compileOnly "com.google.auto.service:auto-service:1.0-rc2" // don't update yet, won't auto generate code

implementation 'com.squareup:javapoet:1.9.0'
implementation 'com.squareup:kotlinpoet:1.0.0-RC1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't break anything? Code is still auto generated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't mean for any one to review this yet. I'm working on another pr that is based off this branch. For now this is just for me to have the Kotlin poet library in the project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pauldg7 Split the changes of "org.jetbrains.kotlin:kotlin-stdlib-jre8:$kotlin_version" "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
off of the javapoet to kotlinpoet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make javapoet to kotlinpoet change
a seprate PR
then code gen code will need modifications

}

repositories {
Expand Down
6 changes: 3 additions & 3 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
ext.kotlin_version = '1.2.20'
ext.realm_version = '5.0.1'
ext.kotlin_version = '1.2.60'
ext.realm_version = '5.4.2'
ext.sdk_version = 25
ext.build_tools_version = '27.0.3'
ext.support_library_version = '25.1.1'
Expand All @@ -13,7 +13,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
classpath 'com.android.tools.build:gradle:3.1.4'
//noinspection DifferentKotlinGradleVersion
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "io.realm:realm-gradle-plugin:$realm_version"
Copy link
Contributor

@JamesDurham JamesDurham Sep 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pauldg7
be carefull about the bumping of android tools at this time.

The cange between android studio 3.1 and 3.2 will be when you want to touch these.

Expand Down
2 changes: 1 addition & 1 deletion query/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ android {

dependencies {
implementation fileTree(include: ['*.jar'], dir: 'libs')
implementation "org.jetbrains.kotlin:kotlin-stdlib-jre8:$kotlin_version"
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
Copy link
Contributor

@JamesDurham JamesDurham Sep 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments at
annotationprocessor/build.gradle

change

compileOnly "com.android.support:support-annotations:$support_library_version"
compileOnly "io.realm:realm-android-library:$realm_version"
}
Expand Down