Add ability to disable preview #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new toggle to enable or disable preview functionality in multiplayer games, as well as the corresponding network packets and command handlers.
- Added new packet IDs and packet types for client and server preview changes
- Updated the MultiplayerGame structure and defaults to include the preview toggle
- Introduced command handling (both in chat bot and packet handlers) for toggling preview
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packets/packet_id.go | Added new packet ID constants for preview enable/disable |
| packets/ServerGameEnablePreview.go | Created a new server packet struct and constructor for preview |
| packets/ClientGameEnablePreview.go | Added new client packet struct for preview changes |
| objects/multiplayer_game.go | Added a new EnablePreview field and default setting |
| multiplayer/redis.go | Updated settings caching to include the preview flag |
| multiplayer/game.go | Added a new SetEnablePreview method to update preview state |
| multiplayer/chat_bot.go | Added a new case to handle the preview command |
| handlers/packets.go | Registered the new packet type for preview toggling |
| handlers/ClientGameEnablePreview.go | Implemented the packet handler to update the preview setting |
Comments suppressed due to low confidence (1)
packets/packet_id.go:142
- [nitpick] The constant name 'PacketIdClientGameChangeEnablePreview' is inconsistent with the corresponding file name 'ClientGameEnablePreview.go'. Consider renaming it to 'PacketIdClientGameEnablePreview' for consistency.
PacketIdClientGameChangeEnablePreview
AiAe
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires https://github.com/Quaver/Quaver.Server.Client/pull/33
Adds EnablePreview toggle and relevant packet for multiplayer games. This does not have any effect on server side, but there is client code to prevent preview being enabled by the player if
EnablePreview == false.Adds a
!mp previewcommand for togglingEnablePreview.