Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fixup, fix handling stdout on python 3.11 #19

Merged
merged 10 commits into from
Dec 21, 2024

Conversation

marmarek
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 22.44898% with 38 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (ba13c18) to head (c4150fe).

Files with missing lines Patch % Lines
splitgpg2/stdiostream.py 21.73% 36 Missing ⚠️
splitgpg2/__init__.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   80.86%   78.81%   -2.05%     
==========================================
  Files           2        3       +1     
  Lines        1348     1397      +49     
==========================================
+ Hits         1090     1101      +11     
- Misses        258      296      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek
Copy link
Member Author

PipelineRefresh

@qubesos-bot
Copy link

qubesos-bot commented Dec 19, 2024

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024122002-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

  • system_tests_gui_tools

    • qui_widgets_disk_space: unnamed test (unknown)
    • qui_widgets_disk_space: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qui-disk-space-widget...
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
  • system_tests_gui_tools@hw7

    • qui_widgets_disk_space: unnamed test (unknown)
    • qui_widgets_disk_space: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qui-disk-space-widget...
  • system_tests_basic_vm_qrexec_gui_xfs

    • switch_pool: Failed (test died)
      # Test died: command 'migrate_templates' failed at /usr/lib/os-auto...

Failed tests

8 failures
  • system_tests_gui_tools

    • qui_widgets_disk_space: unnamed test (unknown)
    • qui_widgets_disk_space: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qui-disk-space-widget...
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_gui_tools@hw7

    • qui_widgets_disk_space: unnamed test (unknown)
    • qui_widgets_disk_space: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qui-disk-space-widget...
  • system_tests_basic_vm_qrexec_gui_xfs

    • switch_pool: Failed (test died)
      # Test died: command 'migrate_templates' failed at /usr/lib/os-auto...
  • system_tests_basic_vm_qrexec_gui_zfs

    • switch_pool: Failed (test died)
      # Test died: command 'migrate_templates' failed at /usr/lib/os-auto...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

2 fixed
  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
  • system_tests_audio@hw1

Unstable tests

  • system_tests_update

    update2/Failed (1/5 times with errors)
    • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...
  • system_tests_update@hw1

    update2/Failed (1/5 times with errors)
    • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...
  • system_tests_update@hw7

    update2/Failed (1/5 times with errors)
    • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...

It's not recommended to use it directly, but copy into own project, so
do just that. See python/cpython#79174
Add support for waiting for stream close.
And actually use the new class.
Those messages are not relevant for the client, and may leak some info
about the configuration.
Since the subkeys-only keyring feature is enabled by default
(source_keyring_dir != "no"), signing with the GnuPG's defaults fails.

Generate a signing subkey using gpg2 --quick-add-key.
Sync with app-linux-split-gpg, especially the following commits:
a652de5 test: avoid false negative from sending status dialog
4bcba03 tests: update for Thunderbird 102
15fda8c tests: disable end-of-year message, and similar popups
b9c13d0 tests: fix clicking top buttons in evolution
d65f098 tests: use distribution's dogtail package
00394da tests: try harder to avoid donation prompt during tests
3bf5616 tests: update for Thunderbird 115
7477c2d tests: switch from smtpd to aiosmtpd
17f96e0 tests: handle both Save and Save All dialogs
e46af5f tests: adjust for Thunderbird 128
@marmarek marmarek merged commit b23c0de into QubesOS:main Dec 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants