Support resetting device on attach #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If device is already attached to usbip-host, leave it there. This avoids any other driver interacting with the device in the short time (if some module gets loaded at this time for example). QubesOS/qubes-issues#
Some device require reset after interacting with previous driver. When device was used with usbip-host before, it took care of that when detaching from previous target (VM). But if it was attached to some other driver in sys-usb before, this needs to be done manually. To limit possible impact, make this opt-in. There are two methods to opt into this feature: 1. Enable it for all devices using (adjust sys-usb name if applicable): qvm-service --enable sys-usb usb-reset-on-attach 2. Enable for specific device by setting QUBES_USB_RESET udev property. QubesOS/qubes-issues#8953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes attaching Nitrokey 3 Bootloader, but may help with other devices too.
Fixes QubesOS/qubes-issues#8953