Add skip-files-fetch option #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
force-pushed
the
skip-fetch-files
branch
3 times, most recently
from
7bf7a38 to
fccd522
Compare
It's useful to fetch just git repos, but not distfiles. It's useful when fetching all repositories, but fetching actual files only when building. Especially saves a lot of space from kernel tarballs. And also, useful when using builder just to verify sources. QubesOS/qubes-issues#9662
Do not override the whole env, just add/replace GNUPGHOME env. This is especially for subprocess to find git or gpg using PATH variable. And also use /usr/bin/env python3 in shebang (similarly to the main qubesbuilder-cli script), do not assume /usr/bin/python3.
If there is no need to use sudo (most of the cases), don't try it. This avoids polluting logs if sudo is not allowed, or even not installed.
marmarek
force-pushed
the
skip-fetch-files
branch
from
7e5af0b to
c56be71
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 78.25% 78.25% -0.01%
==========================================
Files 47 47
Lines 5400 5407 +7
==========================================
+ Hits 4226 4231 +5
- Misses 1174 1176 +2 ☔ View full report in Codecov by Sentry. |
marmarek
force-pushed
the
skip-fetch-files
branch
from
c56be71 to
b9e74d9
Compare
There is --git-commit option for get-and-verify-source.py already. Use its implementation, but keep verifying tags. For that, they need to be fetched.
marmarek
force-pushed
the
skip-fetch-files
branch
from
b9e74d9 to
11e1eec
Compare
Scheduled pipelines on the "main" branch have cache jobs enabled, and those jobs are used by more or less all pipelines in other repos for quicker run. Do this for ordinary "main" pipelines too, otherwise all jobs won't use a cache for a week after merging anything to the builderv2 repo.
marmarek
force-pushed
the
skip-fetch-files
branch
from
8e44502 to
a8d4ec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to fetch just git repos, but not distfiles. It's useful when
fetching all repositories, but fetching actual files only when building.
Especially saves a lot of space from kernel tarballs.
And also, useful when using builder just to verify sources.
QubesOS/qubes-issues#9662