Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to speed up qvm-ls #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Changes to speed up qvm-ls #36

wants to merge 6 commits into from

Commits on Nov 10, 2017

  1. Use GetAll instead of Get and cache property values 

    This is much more efficient.
    @qubesuser
    qubesuser committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    5f152d4 View commit details
    Browse the repository at this point in the history

  2. cache VM state from List/GetAllData instead of requesting it every time

    @qubesuser
    qubesuser committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    7644ea9 View commit details
    Browse the repository at this point in the history

  3. qvm-ls: use GetAllData 

    This makes it get all the data with a single qubesd call.
    @qubesuser
    qubesuser committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    9e1a0bd View commit details
    Browse the repository at this point in the history

  4. don't lookup list of labels just to read VM properties 

    If qubesd returns a label name, we can just assume it's valid.

This makes qvm-ls take only one qubesd call.
    @qubesuser
    qubesuser committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    6eb828f View commit details
    Browse the repository at this point in the history

  5. don't use ast.literal_eval, just directly convert to the desired type 

    It's slow and unnecessary
    @qubesuser
    qubesuser committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    10c4c2f View commit details
    Browse the repository at this point in the history

  6. remove spinner code 

    Tools should be written to be fast enough that spinners don't become necessary.
    @qubesuser
    qubesuser committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    671150d View commit details
    Browse the repository at this point in the history