qubes-dom0-update could check whether /boot is mounted #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
requested changes
Jun 26, 2024
| [[ ${?} -ne 0 ]] && return | ||
| # Ask user to manually mount partition if user is using GUI Updater | ||
| if [ ! -t 1 ]; then | ||
| echo "Could not decide about unmounted ${1} partition in non-interactive/GUI mode!" |
There was a problem hiding this comment.
This doesn't allow overriding the check in non-interactive case. Maybe add some option for that?
There was a problem hiding this comment.
This doesn't allow overriding the check in non-interactive case. Maybe add some option for that?
Is --skip-boot or --skip-boot-check or --skip-boot-upgrade good? And the help text:
--skip-boot do no check if /boot & /boot/efi partitions are mounted.
dom0-updates/qubes-dom0-update
Outdated
| esac | ||
| } | ||
|
|
||
| if [ "$CHECK_ONLY" != "1" ]; then |
There was a problem hiding this comment.
There are more cases when mounting is not necessary or desired: REMOTE_ONLY=1, DOWNLOADONLY=1. In fact CHECK_ONLY implies REMOTE_ONLY already.
|
--skip-boot-check is okay.
…--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062721-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests11 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 5 fixed
Unstable tests
|
This was referenced Jun 27, 2024
marmarek
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: QubesOS/qubes-issues#885