vmupdate: Fix SELinux plugin detection #177
Open
+26
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current plugin always run if the system is detected as fedora. But, SELinux is not always installed (minimal templates for example) or it can be intentionally disabled by the user, meaning the script will throw a chcon error in the update log. Fix that by first checking if SELinux is installed, and then check if the status is Enforcing/Permissive.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 73.03% 73.03%
=======================================
Files 10 10
Lines 1157 1157
=======================================
Hits 845 845
Misses 312 312 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current plugin always run if the system is detected as fedora. But, SELinux is not always installed (minimal templates for example) or it can be intentionally disabled by the user, meaning the script will throw a chcon error in the update log. Fix that by first checking if SELinux is installed, and then check if the status is Enforcing/Permissive.
QubesOS/qubes-issues#9663