Fix markup injection issues #236
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge conflict, otherwise looks fine (but let's tests check it too) |
DemiMarie
force-pushed
the
fix-markup-injection
branch
2 times, most recently
from
81f3f70 to
be5c363
Compare
DemiMarie
force-pushed
the
fix-markup-injection
branch
3 times, most recently
from
4efac67 to
a224c12
Compare
This fixes some (theoretical) markup injection problems. I believe none of the strings that I escape here will ever contain "<" or "&", but it is always safer to escape.
DemiMarie
force-pushed
the
fix-markup-injection
branch
from
a224c12 to
fd9ff2f
Compare
marmarek
reviewed
Dec 14, 2024
| @@ -96,6 +98,20 @@ def check_update(vm) -> bool: | |||
| return True | |||
| return False | |||
|
|
|||
| def _escape_str(s: Union[str, float, int]) -> Union[str, float, int]: | |||
| # pylint: disable=unidiomatic-typecheck | |||
There was a problem hiding this comment.
pylint was right here, use isinstance()
marmarek
reviewed
Dec 14, 2024
| @@ -87,19 +88,21 @@ def setup_menu(self): | |||
| self.tray_menu.set_reserve_toggle_size(False) | |||
|
|
|||
| if self.vms_needing_update: | |||
| self.tray_menu.append(TextItem(_("<b>Qube updates available!</b>"))) | |||
| self.tray_menu.append(TextItem("Qube updates available!")) | |||
There was a problem hiding this comment.
Better apply _() to the string constant (tools extracting strings for translation will be happier).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 93.43% 93.08% -0.35%
==========================================
Files 57 58 +1
Lines 10999 11068 +69
==========================================
+ Hits 10277 10303 +26
- Misses 722 765 +43 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 15, 2024
Wrap all JavaScript in an Immediately-Invoked Function Expression
QubesOS/qubes-desktop-linux-kde#19
Open
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024121519-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable tests
|
This was referenced Dec 15, 2024
|
FWIW openQA says: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some (theoretical) markup injection problems. I believe none of the strings that I escape here will ever contain "<" or "&", but it is always safer to escape.