audio: fix reacting on mic enable/disable requests #161
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
force-pushed
the
audio-watch-fix
branch
from
323ac46 to
3d32ff7
Compare
This was referenced Dec 4, 2024
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024121004-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests4 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 2 fixed
Unstable tests
|
This was referenced Dec 4, 2024
Merged
First of all, after getting an event of QubesDB FD, actually call qdb_read_watch() so the event is cleared and the next one can be received. But that's not enough. libqubesdb's queueing of watches doesn't handle well using the same connection for both watches and commands, and using non-blocking mode (monitoring qdb_watch_fd(), instead of calling qdb_read_watch() in a loop). While this issue wants fixing on the libqubesdb side, for now use separate connection to workaround the issue. Fixes QubesOS/qubes-issues#9619
marmarek
force-pushed
the
audio-watch-fix
branch
from
3d32ff7 to
97c9e36
Compare
This was referenced Dec 6, 2024
marmarek
force-pushed
the
audio-watch-fix
branch
from
0030c81 to
97c9e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After getting an event of QubesDB FD, actually call qdb_read_watch() so
the event is cleared and the next one can be received.
QubesOS/qubes-issues#9619