Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qubes version to boot menu #116

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add qubes version to boot menu #116

merged 1 commit into from
Jul 31, 2024

Conversation

alimirjamali
Copy link
Contributor

@alimirjamali
Copy link
Contributor Author

@marmarek Archlinux build failure is because of this?

QubesOS/qubes-issues#9220

@marmarek
Copy link
Member

@marmarek Archlinux build failure is because of this?

I don't think so. The error: GPGME error: Inappropriate ioctl for device error is something else and I think this is what later is seen as package signature verification failure.

marmarek
marmarek requested changes Jul 16, 2024
View reviewed changes
grub/grub.qubes-kernel-vm-support Outdated Show resolved Hide resolved
@alimirjamali alimirjamali requested a review from marmarek July 16, 2024 16:05
@marmarek
Copy link
Member

I don't think so. The error: GPGME error: Inappropriate ioctl for device error is something else and I think this is what later is seen as package signature verification failure.

QubesOS/qubes-builderv2#137

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Jul 18, 2024 •
edited
Loading

Ouch. I forgot the add $() to the sed command.

p.s. Fixed

@marmarek
Copy link
Member

PipelineRetry

@marmarek marmarek added the openqa-pending PR to be tested in the next OpenQA run label Jul 19, 2024
This was referenced Jul 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@qubesos-bot
Copy link

qubesos-bot commented Jul 19, 2024 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024073102-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update

  • system_tests_audio

Failed tests

7 failures

  • system_tests_pvgrub_salt_storage

    • [unstable] TC_41_HVMGrub_fedora-40-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_41_HVMGrub_fedora-40-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_extra

    • [unstable] TC_00_QVCTest_debian-12-xfce: test_020_webcam (failure + cleanup)
      AssertionError: 26.558837982863633 not less than 2.5

    • [unstable] TC_00_QVCTest_fedora-40-xfce: test_020_webcam (failure + cleanup)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

    • [unstable] TC_00_QVCTest_whonix-gateway-17: test_020_webcam (failure)
      AssertionError: 26.558837982863633 not less than 2.5

    • [unstable] TC_00_QVCTest_whonix-workstation-17: test_020_webcam (failure + cleanup)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

  • system_tests_audio

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/105374#dependencies

4 fixed

Unstable tests

  • system_tests_audio@hw1

    TC_20_AudioVM_PipeWire_whonix-workstation-17/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 107016 AssertionError: too short audio, expected 10s, got 9.09077097505668...

  • system_tests_whonix@hw7

    whonix_torbrowser/ (1/5 times with errors)
    whonix_torbrowser/ (1/5 times with errors)
    whonix_torbrowser/Failed (1/5 times with errors)
    • job 108052 # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

  • system_tests_suspend@hw1

    suspend/ (1/5 times with errors)
    suspend/Failed (1/5 times with errors)
    • job 107593 # Test died: no candidate needle with tag(s) 'xscreensaver-prompt' ...
    suspend/wait_serial (1/5 times with errors)
    • job 107593 # wait_serial expected: qr/2E8vz-\d+-/...

  • system_tests_whonix

    whonix_torbrowser/ (1/5 times with errors)
    whonix_torbrowser/ (1/5 times with errors)
    whonix_torbrowser/Failed (1/5 times with errors)
    • job 108052 # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

  • system_tests_suspend

    suspend/ (1/5 times with errors)
    suspend/Failed (1/5 times with errors)
    • job 107593 # Test died: no candidate needle with tag(s) 'xscreensaver-prompt' ...
    suspend/wait_serial (1/5 times with errors)
    • job 107593 # wait_serial expected: qr/2E8vz-\d+-/...

  • system_tests_pvgrub_salt_storage

    TC_41_HVMGrub_fedora-40-xfce/test_000_standalone_vm (4/5 times with errors)
    • job 105470 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 105874 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 106585 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 107590 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_extra

    TC_00_QVCTest_debian-12-xfce/test_020_webcam (1/5 times with errors)
    • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    TC_00_QVCTest_fedora-40-xfce/test_020_webcam (4/5 times with errors)
    • job 105464 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 105868 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 106579 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    TC_00_QVCTest_whonix-gateway-17/test_020_webcam (5/5 times with errors)
    • job 105464 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 105868 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 106579 self.assertNotEqual(vm.run('test -e /dev/vid... AssertionError: 0 == 0
    • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 107584 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    TC_00_QVCTest_whonix-workstation-17/test_020_webcam (4/5 times with errors)
    • job 105464 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 105868 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
    • job 106579 self.assertNotEqual(vm.run('test -e /dev/vid... AssertionError: 0 == 0
    • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...

  • system_tests_usbproxy

    TC_20_USBProxy_core3_fedora-40-xfce/test_070_attach_not_installed_front (1/5 times with errors)
    • job 105442 qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...

  • system_tests_network_updates

    TC_11_QvmTemplateMgmtVM_debian-12-xfce/test_000_template_list (1/5 times with errors)
    • job 105469 AssertionError: libvirt event impl drain timeout
    TC_10_QvmTemplate_whonix-gateway-17/test_010_template_install (1/5 times with errors)
    • job 105873 AssertionError: libvirt event impl drain timeout

  • system_tests_audio

    TC_20_AudioVM_PipeWire_whonix-workstation-17/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 107016 AssertionError: too short audio, expected 10s, got 9.09077097505668...

  • system_tests_splitgpg

    TC_10_Thunderbird_debian-12-xfce/test_010_send_receive_inline_signed_only (1/5 times with errors)
    • job 105472 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
    TC_10_Thunderbird_whonix-workstation-17/test_020_send_receive_inline_with_attachment (3/5 times with errors)
    • job 105472 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
    • job 105876 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
    • job 106587 dogtail.tree.SearchError: descendent of [application | Thunderbird]...

This was referenced Jul 19, 2024
Merged
Merged
Merged
Merged
Closed
marmarek
marmarek requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config applies to a VMs too. And if fails there on Debian:

debian-12-xfce:out: update-initramfs: Generating /boot/initrd.img-6.1.0-23-amd64
debian-12-xfce:out: /etc/kernel/postinst.d/zz-update-grub:
debian-12-xfce:out: sed: can't read /etc/system-release: No such file or directory
debian-12-xfce:out: run-parts: /etc/kernel/postinst.d/zz-update-grub exited with return code 2

Better make this part apply only to dom0, for example by checking for /etc/qubes-release presence

@marmarek marmarek removed the openqa-pending PR to be tested in the next OpenQA run label Jul 19, 2024
@alimirjamali
Copy link
Contributor Author

Done

@alimirjamali alimirjamali requested a review from marmarek July 19, 2024 10:13
@marmarek marmarek added the openqa-pending PR to be tested in the next OpenQA run label Jul 19, 2024
This was referenced Jul 21, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@qubesos-bot qubesos-bot mentioned this pull request Jul 31, 2024
Merged
@marmarek marmarek merged commit aa87982 into QubesOS:main Jul 31, 2024
1 of 2 checks passed
@alimirjamali alimirjamali deleted the Issue-4663 branch October 29, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmarek marmarek marmarek approved these changes

Assignees
No one assigned
Labels
openqa-pending PR to be tested in the next OpenQA run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add qubes version to boot menu (grub)
3 participants
@alimirjamali @marmarek @qubesos-bot