Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- default-dispvm: whonix-ws-{{ whonix.whonix_version }}-dvm #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrelanos
Copy link
Member

Please very carefully review.
Untested.

- default-dispvm: whonix-ws-{{ whonix.whonix_version }}-dvm similar to https://github.com/QubesOS/qubes-mgmt-salt-dom0-virtual-machines/blob/master/qvm/anon-whonix.sls#L34

Would that work?

Would this fail if whonix-ws-14-dvm does not (yet) exist?

Reason: was somehow still set to whonix-ws-dvm on my system which leads to confusion.
Use case: opening links from Whonix-Gateway such as when seeing some link in konsole or whonixcheck, it could be opened safely in a DispVM based on whonix-ws-14-dvm.

What this is NOT: disposable sys-whonix

//@viq

@marmarek
Copy link
Member

Would this fail if whonix-ws-14-dvm does not (yet) exist?

Yes. And it will not exists because whonix-ws-14-dvm creation depends on sys-whonix (to be set as netvm), so is created later.
To solve this, create separate state (can be in the same file) that set default-dispvm, but depends on both sys-whonix and whonix-ws-14-dvm, something like (untested):

sys-whonix-default-dispvm:
  qvm.prefs:
    - name: sys-whonix
    - default-dispvm: whonix-ws-{{ whonix.whonix_version }}-dvm
    - require:
      - qvm: whonix-ws-{{ whonix.whonix_version }}-dvm
      - qvm: sys-whonix

@marmarek
Copy link
Member

Is it supported configuration to have whonix-gw + sys-whonix only, but not whonix-ws etc? If yes, this change would break such configuration (can be avoided by setting default-dispvm to none here and setting it to whonix-ws-14-dvm only after creating the latter).

@adrelanos
Copy link
Member Author

adrelanos commented Jul 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants