Group indexes by prefix (common table) #1175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablaone
changed the title
nablaone
requested review from
jakozaur,
mieciu,
trzysiek,
avelanarius and
pdelewski
trzysiek
reviewed
Jan 15, 2025
quesma/quesma/config/config_v2.go
Outdated
Comment on lines
737
to
738
| if defaultIngestConfig, ok := queryProcessor.Config.IndexConfig[DefaultWildcardIndexName]; ok { | ||
| conf.DefaultQueryOptimizers = defaultIngestConfig.Optimizers |
There was a problem hiding this comment.
Did you forget to change name to defaultQueryConfig? If not, I don't know what's going on here 😆
pdelewski
reviewed
Jan 29, 2025
| if opt, ok := s.cfg.DefaultQueryOptimizers[groupByCommonTableIndexes]; ok { | ||
| if !opt.Disabled { | ||
| for k, v := range opt.Properties { | ||
| if v != "false" { |
There was a problem hiding this comment.
Can v be only true or false?
There was a problem hiding this comment.
It's a boolean flag for now.
pdelewski
reviewed
Jan 29, 2025
|
|
||
| for _, indexName := range query.Indexes { | ||
| indexWhere = append(indexWhere, model.NewInfixExpr(model.NewColumnRef(common_table.IndexNameColumn), "=", model.NewLiteral(fmt.Sprintf("'%s'", indexName)))) | ||
| var added bool |
There was a problem hiding this comment.
nitpick: This body could be separate function
pdelewski
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Grafana queries daily indexes:
So if we have a 3-year time range, Grafana will send 1k+ indexes in the query. We transform that list into an
ORexpression, and hit the query limit.This PR adds an optimizer that transforms the
ORexpressions into a singlestarsWithexpression when indexes share the same prefix.If we have indexes with a pattern
daily-YYYYMMDD,we can enable the optimizer: