Add Unlicence to allowed license list for go-licence-detector #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
requested review from
nablaone,
jakozaur,
mieciu,
trzysiek and
pdelewski
avelanarius
changed the title
After QuesmaOrg#1212, go-licence-detector GitHub Actions job started failing. One of the added dependencies uses Unlicence licence, which is not on the allowlist of the default go-licence-detector rules list. Unlicence is a public-domain-equivalent licence. The default rules list already allowed similar licences, such as "CC0-1.0" and "Public Domain", so it should be OK to add Unlicence to the allowed list. The added rules.json is a default rules file with only Unlicence added. This fixes the NOTICE.MD generation with go-licence-detector.
avelanarius
force-pushed
the
unlicense
branch
from
421596e to
013ab2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1212, go-licence-detector GitHub Actions job started failing. One of the added dependencies uses Unlicense license, which is not on the allowlist of the default go-licence-detector rules list.
Unlicense is a public-domain-equivalent license. The default rules list already allowed similar licenses, such as "CC0-1.0" and "Public Domain", so it should be OK for us to add Unlicense to the allowed list.
The added rules.json is a default rules file with only Unlicense added.
This fixes the NOTICE.MD generation with go-licence-detector.