Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 #244

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

3.0.0 #244

wants to merge 5 commits into from

Conversation

pauljohanneskraft
Copy link
Collaborator

@pauljohanneskraft pauljohanneskraft commented May 5, 2023

Changelog:

  • Get rid of StrongRouter/WeakRouter/UnownedRouter in favor of existential types in the new Swift versions.
  • Improve interface for less-often used coordinators, e.g. PageCoordinator.
  • Remove jazzy Documentation and replace with documentation from Swift-DocC.

Unresolved Issues:

  • At the moment, whenever an any Router<RouteType> is used in a transition, it requires a .asPresentable to "convert" it to make it conform to Presentable, which it already does. It would work fine for iOS 16+, but it makes no sense to restrict this library in this way and it makes it harder for beginners to use transitions with existential routers in general.

@andrefmsilva
Copy link

Hi @pauljohanneskraft, any news about this?

@pauljohanneskraft
Copy link
Collaborator Author

Hey @andrefmsilva ! I'm still working on some of these changes and think of some additional features (or if there is going to be some anyways), but I would like to have that finished, since these changes will require a major version update. Do you already have any remarks regarding the current changes in this branch?

@andrefmsilva
Copy link

Hi, i will update my app to use this branch and run some tests to see if i find some problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants