first looks into 1.20.4 #516
Conversation
(mostly new classes)
moehreag
added
s: medium
|
codec stuff goes in |
ix0rai
added
v: release
|
BlockCodecs isn't a correct name, as the bound registry uses id of |
Hmm... looking at the class again maybe |
|
|
|
It's not a registry either, the closest thing would be Blocks or Items class |
|
Also being in the |
alright! |
There was a problem hiding this comment.
AFAICT QMap doesn't use o for objects unless it's for equals(Ljava/lang/Object;)Z, and I'm not sure about any of the single-letter names of these params (except i).
I think it could make sense to use them for primitives (and maybe Objects), but the convention should be made clear if so.
There was a problem hiding this comment.
AFAICT QMap doesn't use
ofor objects unless it's forequals(Ljava/lang/Object;)Z, and I'm not sure about any of the single-letter names of these params (excepti). I think it could make sense to use them for primitives (and maybeObjects), but the convention should be made clear if so.
It is entirely possible that using o for object parameters is something I entirely made up and isn't used anywhere and mentioned in any conventions (except for equals methods)
| METHOD m_rxpnwroz toMap (Lcom/mojang/serialization/MapLike;)Ljava/util/Map; | ||
| ARG 0 mapLike | ||
| METHOD m_sfvskaol (Ljava/lang/Object;)Ljava/lang/Object; | ||
| ARG 0 object |
There was a problem hiding this comment.
inconsistent with other o params
| ARG 0 object | ||
| METHOD mapBuilder mapBuilder ()Lcom/mojang/serialization/RecordBuilder; | ||
| METHOD mergeToList mergeToList (Ljava/lang/Object;Ljava/lang/Object;)Lcom/mojang/serialization/DataResult; | ||
| ARG 1 o |
There was a problem hiding this comment.
| ARG 1 o | |
| ARG 1 o1 |
| ARG 1 o | ||
| ARG 2 o2 | ||
| METHOD mergeToList mergeToList (Ljava/lang/Object;Ljava/util/List;)Lcom/mojang/serialization/DataResult; | ||
| ARG 1 object |
| ARG 1 o | ||
| ARG 2 mapLike | ||
| METHOD mergeToMap mergeToMap (Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Lcom/mojang/serialization/DataResult; | ||
| ARG 1 o |
There was a problem hiding this comment.
| ARG 1 o | |
| ARG 1 o1 |
| ARG 2 map | ||
| METHOD remove remove (Ljava/lang/Object;Ljava/lang/String;)Ljava/lang/Object; | ||
| ARG 1 map | ||
| ARG 2 s |
There was a problem hiding this comment.
| ARG 2 s | |
| ARG 2 string |
s is used for short in other places, and I think if single letters are used, they should be for primitives (and maybe Objects)
| ARG 1 string | ||
| CLASS C_wogpegfy MapBuilder | ||
| METHOD append (Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object; | ||
| ARG 1 o |
There was a problem hiding this comment.
| ARG 1 o | |
| ARG 1 o1 |
These are just mostly the unmapped classes I quickly found names for.
Things I'm not sure about:
BlockCodecsshould probably not be in theblockpackage. Where should it go?