Map a whole bunch of stuff #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IotaBread
added
t: new
pyrox0
changed the title
pyrox0
changed the title
IotaBread
added
s: large
supersaiyansubtlety
requested changes
Jan 13, 2024
There was a problem hiding this comment.
I tried to compare and comment on any conflicts between this PR and #523's block changes.
I also requested some changes to some wall block class names (and a few other misc blocks) that I only noticed because this PR maps their codec fields. I didn't use github's suggestion feature for class names since they need to be changed in enigma.
|
Updated the blocks commit based on the suggested changes! Edit: I'm aware of the lint errors, working on fixing them, will hopefully have a better set of mappings uploaded by tomorrow. Edit 2: Fixed the lint errors! |
Now at 99.0%! Up about 4.5% from when I started :)
100%! 🎉
99.8%(471/472), only one that's missing is a mysterious constant in Scoreboard that Yarn doesn't have a name for either, so I didn't map it.
kaBAM, another mapping bites the dust
*DJ Khaled voice* Another one
supersaiyansubtlety
approved these changes
Jan 13, 2024
ix0rai
approved these changes
Jan 16, 2024
ix0rai
added
final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, n/m/command is now fully mapped to the best of my ability, as well as n/m/block to 99%!(8433/8517)
Most of n/m/block was adding CODEC entries for all the blocks, which took a while but shouldn't need to be done again in the future.
n/m/command wasn't too bad, just a bunch of thorny logic to reason through, but I got there in the end.
n/m/scoreboard is essentially fully mapped as well, with only one mysterious field in the Scoreboard class missing. Required pulling a bunch of unmapped stuff out, but got that untangled as well, so that should be done too!
n/m/client/realms also has a bunch of thorny logic, as is to be expected, but pulled that out and it's good now
n/m/resource was trivial.
Feedback is of course welcome. I know there are a few conflicts(or at least similar/identical changes) in #523 , but I'm glad to remove my changes that conflict with the ones in that PR if needed!