-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly load default language entries from mods and Minecraft. #229
Properly load default language entries from mods and Minecraft. #229
Conversation
This fixes dedicated servers not having any language entries loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y E S
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesssss
ComputerCraft has an equivalent mixin. What would you recommend they do? cc-tweaked/cc-restitched#133 |
Fabric API recently got a similar mixin, though I take a wildly different approach. I think dropping the mixin there would make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick
...esource_loader/src/main/java/org/quiltmc/qsl/resource/loader/mixin/server/LanguageMixin.java
Outdated
Show resolved
Hide resolved
…ource/loader/mixin/server/LanguageMixin.java Co-authored-by: Eli Orona <[email protected]>
This fixes dedicated servers not having any language entries loaded.