Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly load default language entries from mods and Minecraft. #229

Conversation

LambdAurora
Copy link
Contributor

This fixes dedicated servers not having any language entries loaded.

This fixes dedicated servers not having any language entries loaded.
@LambdAurora LambdAurora added bug Something isn't working library: core Related to the core library. t: new api This adds a new API. s: tested This pull request has been tested and confirmed as working. labels Dec 5, 2022
@LambdAurora LambdAurora added this to the Initial release milestone Dec 5, 2022
@LambdAurora LambdAurora self-assigned this Dec 5, 2022
@LambdAurora LambdAurora requested a review from a team as a code owner December 5, 2022 11:35
Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@Leo40Git Leo40Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y E S

Copy link

@TibiNonEst TibiNonEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss

@Gaming32
Copy link

Gaming32 commented Dec 5, 2022

ComputerCraft has an equivalent mixin. What would you recommend they do? cc-tweaked/cc-restitched#133

@LambdAurora
Copy link
Contributor Author

ComputerCraft has an equivalent mixin. What would you recommend they do? cc-tweaked/cc-restitched#133

Fabric API recently got a similar mixin, though I take a wildly different approach.

I think dropping the mixin there would make sense.

Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick

…ource/loader/mixin/server/LanguageMixin.java

Co-authored-by: Eli Orona <[email protected]>
@LambdAurora LambdAurora merged commit b3fbb43 into QuiltMC:1.19 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working final-comment-period library: core Related to the core library. s: tested This pull request has been tested and confirmed as working. t: new api This adds a new API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants