Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chatmessage parameter #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vacla
Copy link
Contributor

@vacla vacla commented Apr 15, 2024

untested as i'm not sure how to build it

@vacla vacla requested a review from a team as a code owner April 15, 2024 20:54
@DrexHD
Copy link
Contributor

DrexHD commented Apr 15, 2024

Interesting, but I am not sure if adding this option as a command parameter is the best approach. I feel like it could confuse the average user. Maybe some packet level communication could be added.

@vacla
Copy link
Contributor Author

vacla commented Apr 15, 2024

@DrexHD I'm also not sure if it is correctly written in kotlin on line https://github.com/QuiltServerTools/Ledger/pull/246/files#diff-792ed5b4d8bf3b0b48638241dc6ae05592ac1ab0d66190709f177971b47b8868R33 .
If we allow them to have a parameter also, then they can also just sent it using chat also and see the results there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants