Added alternate data streams finder #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabott
commented
Sep 16, 2022
mabott
commented
|
feel free to reject this if you prefer a different branch, I just realized I sent it to main from my fork |
Gandalf-
requested changes
Sep 20, 2022
| # print(_args) | ||
|
|
||
| @staticmethod | ||
| def get_named_streams(file_obj: FileInfo, work_obj: Worker) -> Optional[str]: |
There was a problem hiding this comment.
It looks like you want -> Sequence[Tuple[str, str]] here?
|
|
||
| @staticmethod | ||
| def work_start(_work_obj: Worker) -> None: | ||
| FILE_NAME = ADSFinder.get_logfile_name(_work_obj.start_path) |
There was a problem hiding this comment.
Nitpick: FILE_NAME should be lower case since it's not a global variable
Comment on lines
+38
to
+40
| res = self.get_named_streams(file_obj, work_obj) | ||
| if res: | ||
| for r in res: |
There was a problem hiding this comment.
You could collapse this to
for stream in self.get_named_streams(file_obj, work_obj):
...
since iterating an empty list will be a no-op
| def every_batch( # pylint: disable=no-self-use | ||
| self, file_list: Sequence[FileInfo], work_obj: Worker | ||
| ) -> None: | ||
| action_count = 0 |
There was a problem hiding this comment.
acount_count isn't getting incremented anywhere; this and line 48 could be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.