Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple features and fixes to qwalk.py #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thebillness
Copy link

Logging:

  • Added unique log file naming by default.
  • Added a "None" option for the logging parameter (-l) that will direct logging to devNull (cross-platform).

Passwords

  • Added option to securely provide the password via getpass and removed the default of 'admin' from the password parameter (-p).

Foot-Gun Prevention

  • Added a check and override parameter (-f) for preventing the script from running directly on a Qumulo node.

Added unique log file naming by default.
Added a "None" option for logging that will direct logging to devNull (cross-platform)
Added option to securely provide the password via getpass and removed the default of 'admin' from the parameter.
Added a check and override parameter for preventing the script from running directly on a Qumulo node.
@WaffleThief123
Copy link

Is there a particular reason for the check + override for running directly on a Q node? IME nodes have enough hardware resources to do this safely (unless the cluster is in the middle of an upgrade, node add, or disk replacement)

@thebillness
Copy link
Author

Is there a particular reason for the check + override for running directly on a Q node? IME nodes have enough hardware resources to do this safely (unless the cluster is in the middle of an upgrade, node add, or disk replacement)

Recommendation of Qumulo support:

qwalk must not be run from a Node. It should be run from an external Linux or Windows client

@WaffleThief123
Copy link

Guess it's a new rec since I was working support there, will keep it in mind :)

@thebillness
Copy link
Author

Well, I did take down two nodes with it, so I might have helped solidify that recommendation. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants