Various Issue Fixes #168
Merged
Various Issue Fixes #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no client connects within 30 seconds of requesting, close the server. This prevents multiple servers from being created and never closing.
Since a passive server is created for an individual client, when it disconnects from the server we can assume the server is done and should close it.
By setting the encoding, there becomes issues with binary transfers (such as photos).
This was referenced Jul 22, 2019
This was referenced Aug 8, 2019
If we do not send back a response, some FTP clients can fail, when they use encryption.
`promisifyAll` will throw if a method with the suffix `Async` already exists. Fixes: #159
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Fixes:
Promise.promisifyAllbreaks other libraries - use safer approach #159