This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Fix missing road names at higher zooms #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also note that this change may (logically) lead to text overlapping on some crossroads
|
|
The root cause is described in mapbox/mapbox-gl-js#9095 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes [what seems to be] a working fix for the rendering bug where street names disappear at very high zoom levels, making the map barely usable in some cases.
The fix is to allow overlapping of labels with over features after a threshold zoom, as apparently MapBoxGL rendering algorithm was considering labels in some area were always overlapping something at high zooms… Strangely, this doesn't happen everywhere, but in cities it's really common.
So, I'm not sure this fixes the original reason, but it seems to work visually. There are some strange placement issues though, like in the last screenshot here where the names are not centered on the road geometry.
Maybe it needs some more investigation.