tests: fixed failed symlink tests on windows due to permission error ... #722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
There were intermittent CI failures on Windows caused by tests that assert POSIX-style file permission bits (chmod/execute bits). Windows' permission/ACL model doesn't behave the same way, so those tests can fail even though the product code is fine. This PR guards those permission-sensitive tests and skips them on Windows (
process.platform === 'win32) so CI stops producing false negatives. It’s a pragmatic short-term fix to keep CI healthy while preserving behavior verification on macOS/Linux.Dive Deeper
What was happening
A subset of unit tests assert or manipulate POSIX-style file mode bits (read/write/execute). On Windows those expectations are unreliable because:
fs.chmodand related permission semantics behave differently (or are effectively no-ops) on Windows runners.As a result, CI on
windows-latestwas reporting failing tests that were not indicative of real regressions in the code.What I changed
Linked issues / bugs